Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync simulation without defining a clock period runs forever #522

Closed
korken89 opened this issue Nov 2, 2020 · 2 comments
Closed

Sync simulation without defining a clock period runs forever #522

korken89 opened this issue Nov 2, 2020 · 2 comments
Labels
duplicate

Comments

@korken89
Copy link

korken89 commented Nov 2, 2020

Hi,

When testing out this framework I ran into the following bug, when running a simulation and forgetting to include the add_clock, the simulation runs forever without error.
E.g.

    sim = Simulator(m)
    # sim.add_clock(1e-6) # removing this line causes simulation to run forever

I would expect to get an error, instead of the current behavior.

Thanks for a great framework!
@whitequark
Copy link
Member

Duplicate of #442. (I'm well aware that this is a common and frustrating issue--the recent simulator refactoring was intended to make addressing this one easier.)

@korken89
Copy link
Author

korken89 commented Nov 2, 2020

Thanks, it's known then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @korken89