Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor-browser-bundle-bin: mark as broken #102540

Merged
merged 1 commit into from Nov 3, 2020
Merged

Conversation

yurkobb
Copy link
Contributor

@yurkobb yurkobb commented Nov 2, 2020

NoScript is missing / broken; Highest Security Level doesn't disable JavaScript.

See issue #83096 for more info.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

NoScript is missing / broken; Highest Security Level doesn't disable
JavaScript.

See issue NixOS#83096 for more info.
@SuperSandro2000
Copy link
Member

NoScript is missing / broken; Highest Security Level doesn't disable
JavaScript.

That line break threw me off for like 10 minutes.

@yurkobb
Copy link
Contributor Author

yurkobb commented Nov 2, 2020

NoScript is missing / broken; Highest Security Level doesn't disable
JavaScript.

That line break threw me off for like 10 minutes.

Fixed.

@xaverdh
Copy link
Contributor

xaverdh commented Nov 3, 2020

This should probably be merged ASAP, is someone with commit access online we can ping on this?

@joachifm joachifm merged commit a3c9217 into NixOS:master Nov 3, 2020
@xaverdh
Copy link
Contributor

xaverdh commented Nov 3, 2020

Since #98564 was backported so should this.
(I checked that even 10.0 was already affected by this bug)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants