Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spidermonkey: 78.1.0 -> 78.4.0 #102543

Merged
merged 1 commit into from Nov 6, 2020
Merged

spidermonkey: 78.1.0 -> 78.4.0 #102543

merged 1 commit into from Nov 6, 2020

Conversation

lostnet
Copy link
Contributor

@lostnet lostnet commented Nov 2, 2020

Motivation for this change

This is a minor update, but has some security fixes https://www.mozilla.org/en-US/firefox/78.4.0/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar November 2, 2020 22:56
@lostnet
Copy link
Contributor Author

lostnet commented Nov 3, 2020

Aside from the direct update, I made the following changes:

  1. The previous patches were promised to be integrated in 78.2 and seem to be (I verifiied that they all get rejected when applied to 78.4). So I removed them.

  2. Spidermonkey commands have a version specific name that was copied without change since _60, I fixed that and verified it doesn't break dependent builds.

@lostnet
Copy link
Contributor Author

lostnet commented Nov 5, 2020

@doronbehar @mkg20001 I'm happy if @abbradar is interested in this, but looking at the history, I think spidermonkey_78 was primarily of interest to one of you as a dependency of cjs.

@doronbehar
Copy link
Contributor

@doronbehar @mkg20001 I'm happy if @abbradar is interested in this, but looking at the history, I think spidermonkey_78 was primarily of interest to one of you as a dependency of cjs.

Once the gnome 3.38 update will land in the unstable channels, I'd be able to test this PR and give it a 👍 . But maybe it'd be wise to merge it beforehand, since it's security related, 🤷‍♂️ .

@jtojnar jtojnar merged commit 4b80de5 into NixOS:master Nov 6, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Nov 6, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lostnet @doronbehar @jtojnar @ajs124