Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/promtail: Add a promtail module #102541

Merged
merged 1 commit into from Nov 3, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Nov 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @WilliButz

Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the module 👍
I have just one small suggestion:

nixos/modules/services/logging/promtail.nix Outdated Show resolved Hide resolved
@WilliButz WilliButz merged commit 0916fea into NixOS:master Nov 3, 2020
@ajs124 ajs124 deleted the init/promtail branch November 3, 2020 16:52
users.users.promtail = {
description = "Promtail service user";
isSystemUser = true;
group = "promtail";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the default usecase would be logging the journal, then it would be advantgeous to add

extraGroups = lib.mkDefault [ "systemd-journal" ];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants