Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capitaine-cursors: fix build with inkscape => 1.0 #102526

Merged
merged 1 commit into from Nov 25, 2020
Merged

capitaine-cursors: fix build with inkscape => 1.0 #102526

merged 1 commit into from Nov 25, 2020

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Nov 2, 2020 •
edited

Motivation for this change

Without this, all cursors are empty resulting in X to fall back to the default cursors.

As shown on hydra, there were a bunch of warnings about a function being deprecated, and xcursorgen failed to read the PNG files generated.

Things done

I've added a patch which is already merged upstream, but barely didnt make it into an release which fixes all of these problems. Also did some minor formatting changes.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from eadwu November 2, 2020 20:46
@eadwu
Copy link
Member

eadwu commented Nov 2, 2020

The error comes from a missing fonts.conf file if I remember correctly, which can be fixed using FONTCONFIG_FILE = makeFontsConf { fontDirectories = [ ]; }; if I copied the right line.

@IvarWithoutBones
Copy link
Member Author

The error comes from a missing fonts.conf file if I remember correctly, which can be fixed using FONTCONFIG_FILE = makeFontsConf { fontDirectories = [ ]; }; if I copied the right line.

That worked, thanks!

eadwu
eadwu approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building fine on my end.

Probably will test it out on my configuration later once I have the time and find my old configuration. I originally thought the configuration was broken and not the derivation.

eadwu
eadwu approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102526 run on x86_64-linux 1

1 package built:
  • capitaine-cursors

@SuperSandro2000 SuperSandro2000 merged commit 7b6ccbf into NixOS:master Nov 25, 2020
@IvarWithoutBones IvarWithoutBones deleted the empty-capitaine-cursors-fix branch November 25, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eadwu eadwu eadwu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvarWithoutBones @eadwu @SuperSandro2000