Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.battery-status: remove (broken) #102555

Merged
merged 1 commit into from Nov 3, 2020
Merged

gnomeExtensions.battery-status: remove (broken) #102555

merged 1 commit into from Nov 3, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

upsstream project is no more maintained for recent
gnome-shell releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
gnomeExtensions.battery-status: remove (broken)
fe4c52b 
upsstream project is no more maintained for recent
gnome-shell releases
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 3, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/272

@kevincox kevincox merged commit c6ec0ec into NixOS:master Nov 3, 2020
@freezeboy freezeboy deleted the remove-gnome-shell-extension-battery-status branch November 3, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @nixos-discourse @kevincox