Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango: Import a patch to fix an issue with Pidgin #102534

Closed
wants to merge 1 commit into from

Conversation

wahjava
Copy link
Contributor

@wahjava wahjava commented Nov 2, 2020

Motivation for this change

There is a bug in Pidgin which seems to happen due to a bug in Pango.

I have only tested the patch by using a custom derivation:

pkgs.pidgin.override {
  gtk2 = (pkgs.gtk2.override {
    pango = (pkgs.pango.overrideAttrs (old:
      {
        patches = old.patches ++ [
          (pkgs.fetchpatch {
            url = "https://gitlab.gnome.org/GNOME/pango/-/commit/948e0b0cb5319adfa956f08c40dd1ea85855a424.patch";
            sha256 = "03vhqpnsq6gzvsd0sz7n5126zrp1b4kfbbfmhc1pmay3rp2ifz7w";
          })
        ];
      }));
  });
}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wahjava wahjava requested a review from rnhmjoj November 2, 2020 21:28
# Fix issue with Pango which is breaking Pidgin
# See https://gitlab.gnome.org/GNOME/pango/-/issues/490
# Remove on next release.
(pkgs.fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't build without this

Suggested change
(pkgs.fetchpatch {
(fetchpatch {

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 3, 2020

This has already been fixed by bumping pango to 1.47.0, see #101458.
The commit hasn't made into master yet, though. Since pango has meny reverse depencencies it had to go though staging.

@wahjava
Copy link
Contributor Author

wahjava commented Nov 4, 2020

Since it seems to be already resolved by #101458 I'll just close this one.

@wahjava wahjava closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants