Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-ls: 0.7.0 -> 0.11.0, switch to buildGoModule #102563

Merged
merged 1 commit into from Dec 11, 2020
Merged

terraform-ls: 0.7.0 -> 0.11.0, switch to buildGoModule #102563

merged 1 commit into from Dec 11, 2020

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Nov 3, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@onsails
Copy link
Contributor Author

onsails commented Nov 3, 2020

Result of nixpkgs-review pr 102563 1

1 package built:
  • terraform-ls

@bhipple
Copy link
Contributor

bhipple commented Nov 3, 2020

Result of nixpkgs-review pr 102563 1

1 package failed to build:
- terraform-ls

@bhipple
Copy link
Contributor

bhipple commented Nov 3, 2020 •
edited 

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/bhipple/.cache/nixpkgs-review/pr-102563/build.nix
builder for '/nix/store/n61ca2204r8vbi0xmmmsdvx7r90200q0-terraform-ls-0.8.0.drv' failed with exit code 1; last 10 log lines:
  ok       github.com/hashicorp/terraform-ls/internal/terraform/addrs      0.003s
  === RUN   TestExec_timeout
      exec_test.go:71: error fetching checksums: Get "https://releases.hashicorp.com/terraform/0.13.1/terraform_0.13.1_SHA256SUMS": dial tcp: lookup releases.hashicorp.com on [::1]:53: read udp [::1]:43802->[::1]:53: read: connection refused
  --- FAIL: TestExec_timeout (0.00s)
  === RUN   TestExec_cancel
      exec_test.go:71: error fetching checksums: Get "https://releases.hashicorp.com/terraform/0.13.1/terraform_0.13.1_SHA256SUMS": dial tcp: lookup releases.hashicorp.com on [::1]:53: read udp [::1]:55281->[::1]:53: read: connection refused
  --- FAIL: TestExec_cancel (0.00s)
  FAIL
  FAIL      github.com/hashicorp/terraform-ls/internal/terraform/exec       0.008s
  FAIL
cannot build derivation '/nix/store/acnc7gzrip1ffzyjwb2lk89rzriblxiy-env.drv': 1 dependencies couldn't be built
[2 built (1 failed), 0.0 MiB DL]

Can you rebuild your FOD with --check to see if it's reproducible for you?

@onsails
Copy link
Contributor Author

onsails commented Nov 3, 2020

hmm, I've reproduced it with --check. I suppose I just make doCheck = false to prevent downloads made by tests in sandbox mode.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102563 run on x86_64-darwin 1

1 package built:
  • terraform-ls

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/370

@onsails
Copy link
Contributor Author

onsails commented Nov 21, 2020

@GrahamcOfBorg eval

@onsails onsails force-pushed the terraform-ls branch 2 times, most recently from 5f0ba7b to 353686a Compare November 21, 2020 20:55
@onsails onsails changed the title terraform-ls: 0.7.0 -> 0.8.0, switch to buildGoModule terraform-ls: 0.7.0 -> 0.10.0, switch to buildGoModule Nov 21, 2020
@onsails onsails changed the title terraform-ls: 0.7.0 -> 0.10.0, switch to buildGoModule terraform-ls: 0.7.0 -> 0.11.0, switch to buildGoModule Dec 10, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102563 run on x86_64-linux 1

1 package built:
  • terraform-ls

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102563 run on x86_64-darwin 1

1 package built:
  • terraform-ls

@SuperSandro2000 SuperSandro2000 merged commit a6947a5 into NixOS:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@martinbaillie martinbaillie Awaiting requested review from martinbaillie

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@onsails @bhipple @SuperSandro2000 @nixos-discourse