Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/chrony: fix owner of chrony drift file #102528

Merged
merged 1 commit into from Nov 3, 2020
Merged

nixos/chrony: fix owner of chrony drift file #102528

merged 1 commit into from Nov 3, 2020

Conversation

wizeman
Copy link
Member

@wizeman wizeman commented Nov 2, 2020

Motivation for this change

It had become owned by root due to #97546.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wizeman
nixos/chrony: fix owner of chrony drift file
48f8b85 
It had become owned by root due to NixOS#97546.
@wizeman
Copy link
Member Author

wizeman commented Nov 2, 2020

cc @kevincox @ajs124 @flokli

ajs124
ajs124 approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but I haven't tested this.

@kevincox kevincox merged commit f1153d8 into NixOS:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@kevincox kevincox kevincox approved these changes

@ajs124 ajs124 ajs124 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wizeman @thoughtpolice @kevincox @ajs124