Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orc: 0.4.29 -> 0.4.32 #102529

Merged
merged 1 commit into from Nov 18, 2020
Merged

orc: 0.4.29 -> 0.4.32 #102529

merged 1 commit into from Nov 18, 2020

Conversation

CrystalGamma
Copy link
Contributor

  • transition from name to pname + version
  • change the build system to meson, as autotools is no longer supported by upstream
  • optionally build devdoc output
  • whatever the reason for manipulating the pkgconfig,
    omitting it doesn't seem to break the build of orc
    or its direct reverse dependencies
Motivation for this change

The old version had a test failure on ppc64le (CC @r-burns).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested build of all direct reverse dependencies (as found by grepping nixpkgs) except mendeley
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

orc: 0.4.29 -> 0.4.32
e291e6a 
* transition from name to pname + version
* change the build system to meson, as autotools is no longer supported by upstream
* optionally build devdoc output
* whatever the reason for manipulating the pkgconfig,
  omitting it doesn't seem to break the build of orc
  or any of its direct reverse dependencies
r-burns
r-burns reviewed Nov 14, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this is working on ppc64le now :)
Hadn't heard of devdoc before, thanks for the link
I think this should go into staging due to linux rebuilds? Otherwise LGTM

@FRidh FRidh changed the base branch from master to staging November 18, 2020 14:50
@FRidh FRidh merged commit d0878be into NixOS:staging Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@r-burns r-burns r-burns left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CrystalGamma @SuperSandro2000 @r-burns @FRidh