Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.coc-diagnostic: init at 0.9.0 #100822

Merged
merged 1 commit into from Oct 17, 2020
Merged

nodePackages.coc-diagnostic: init at 0.9.0 #100822

merged 1 commit into from Oct 17, 2020
+232 −315

Conversation

expipiplus1
Copy link
Contributor

Also add as Vim plugin

Also update node packages from generate.sh

Have Tested vim plugin, haven't tested every other node plugin

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@expipiplus1
nodePackages.coc-diagnostic: init at 0.9.0
9fa1ea7 
Also add as Vim plugin

Also update node packages from generate.sh
@ofborg ofborg bot requested a review from midchildan October 17, 2020 13:27
@expipiplus1
Copy link
Contributor Author

I followed the instructions in the nodePackges readme, but isn't it a bit odd that to add this package I end up updating all the node packages?

@jonringer
Copy link
Contributor

I followed the instructions in the nodePackges readme, but isn't it a bit odd that to add this package I end up updating all the node packages?

this is done so that the node packages can be "shared" with other packages which also use node packages

jonringer
jonringer approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100822 1

2 packages marked as broken and skipped:
  • image_optim
  • ripcord
13 packages built:
  • emojione
  • epgstation
  • joplin
  • lumo
  • mirakurun
  • netlify-cli
  • redoc-cli
  • thelounge
  • twemoji-color-font
  • vimPlugins.coc-diagnostic
  • vimPlugins.coc-prettier
  • vimPlugins.coc-stylelint
  • wasm-text-gen

@jonringer jonringer merged commit 0e29b48 into NixOS:master Oct 17, 2020
@expipiplus1 expipiplus1 deleted the joe-coc-diagnostic branch October 17, 2020 16:24
@expipiplus1
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@expipiplus1 @jonringer