Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] apparmor: 2.13.4 -> 2.13.5 #100842

Merged
merged 1 commit into from Oct 20, 2020
Merged

[staging] apparmor: 2.13.4 -> 2.13.5 #100842

merged 1 commit into from Oct 20, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 17, 2020

Motivation for this change

Upstream release:

Meanwhile, there's also a new major release, out: https://gitlab.com/apparmor/apparmor/-/wikis/Release_Notes_3.0
As with any major release, there are some backwards incompatible changes, so the migration might require changes, announcements or maybe just some kind of plan…

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt changed the title apparmor: 2.13.4 -> 2.13.5 [staging] apparmor: 2.13.4 -> 2.13.5 Oct 17, 2020
@ajs124 ajs124 marked this pull request as ready for review October 18, 2020 00:01
@ajs124
Copy link
Member Author

ajs124 commented Oct 20, 2020

Looks like there's some patching that should probably be done: https://gitlab.com/apparmor/apparmor/-/commit/145136f6041aba4fffbbf8d1a5df368998b81ca1

@SuperSandro2000
Copy link
Member

JFYI AppArmor 3.0 is currently not compatible with Docker.

@FRidh FRidh merged commit b2602d1 into NixOS:staging Oct 20, 2020
@ajs124 ajs124 deleted the upd/apparmor branch October 20, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm Awaiting requested review from joachifm

@Phreedom Phreedom Awaiting requested review from Phreedom

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @SuperSandro2000 @FRidh