Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] glibc: 2.32 -> 2.32-10 #100813

Merged
merged 1 commit into from Dec 8, 2020
Merged

[staging] glibc: 2.32 -> 2.32-10 #100813

merged 1 commit into from Dec 8, 2020

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Oct 17, 2020 •
edited

Motivation for this change

This should fix #100799 thanks to
https://sourceware.org/bugzilla/show_bug.cgi?id=26534#c5

EDIT: well, I think we should fix the FMA problem anyway :-) Surely there's some common SW using functions like pow().

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • N/A macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all some :-) pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • N/A Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra and Ma27 October 17, 2020 12:58
@FRidh FRidh added this to WIP in Staging via automation Oct 20, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Oct 20, 2020
@Ma27
Copy link
Member

Ma27 commented Nov 3, 2020

@vcunat what's the status here?

@vcunat
Copy link
Member Author

vcunat commented Nov 3, 2020

Nothing new. I'd still merge, though there seems to be no need to hurry and I'd most likely include new patches from upstream (added since then).

@vcunat vcunat mentioned this pull request Nov 12, 2020
Closed
10 tasks
@jonringer jonringer changed the title glibc: 2.32 -> 2.32-10 [staging] glibc: 2.32 -> 2.32-10 Nov 24, 2020
@FRidh FRidh merged commit 098a7b6 into NixOS:staging Dec 8, 2020
Staging automation moved this from Needs review to Done Dec 8, 2020
@TredwellGit TredwellGit mentioned this pull request Dec 8, 2020
Merged
3 tasks
@vcunat vcunat deleted the p/glibc-patches branch January 26, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcunat @Ma27 @FRidh