Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.IOAsyncSSL: init at 0.22 #100820

Merged
merged 1 commit into from Oct 17, 2020
Merged

perlPackages.IOAsyncSSL: init at 0.22 #100820

merged 1 commit into from Oct 17, 2020

Conversation

zakame
Copy link
Member

@zakame zakame commented Oct 17, 2020 •
edited

Motivation for this change

This pure-Perl addon for IO::Async extends it to allow creating TLS/SSL servers or clients via IO::Socket::SSL.

This is a somewhat required module for other IO::Async-based code that connect/serve TLS/SSL resources, such as those in the Net::Async namespace.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner October 17, 2020 13:08
@stigtsp
Copy link
Member

stigtsp commented Oct 17, 2020

@GrahamcOfBorg build perlPackages.IOAsyncSSL perldevelPackages.IOAsyncSSL

stigtsp
stigtsp approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Thanks for the contribution!

Result of nixpkgs-review pr 100820 1

2 packages built:
  • perl530Packages.IOAsyncSSL
  • perl532Packages.IOAsyncSSL

@stigtsp stigtsp merged commit 5c5e7b1 into NixOS:master Oct 17, 2020
@zakame
Copy link
Member Author

zakame commented Oct 17, 2020

Thanks again! 👍

@zakame zakame deleted the zakame/contrib/perl-IOAsyncSSL branch October 17, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zakame @stigtsp