Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger: apply review suggestions #100839

Merged
merged 1 commit into from Oct 17, 2020
Merged

trigger: apply review suggestions #100839

merged 1 commit into from Oct 17, 2020

Conversation

p-h
Copy link
Contributor

@p-h p-h commented Oct 17, 2020

Cost me a good 2h until I figured out that trigger saves it's resource path in your home directory and you have to delete that file for every unique build.

Motivation for this change

Application of review suggestions from @jonringer from #100492

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100839 1

1 package built:
  • trigger

@jonringer jonringer merged commit c6218f2 into NixOS:master Oct 17, 2020
@ofborg ofborg bot requested a review from viric October 17, 2020 16:02
@p-h p-h deleted the trigger-fixup branch October 17, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p-h @jonringer