New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nim: 1.2.6 -> 1.4.0 #100826
nim: 1.2.6 -> 1.4.0 #100826
Conversation
The hash in this commit seems to be wrong. Did the tarball change again?
|
@ehmry do you still have the source tarball with sha256 |
@petabyteboy I do not. If this is how they are going to do releases then we should stay one version behind. |
Hi! @ehmry @petabyteboy is there a chance this will get merged, or not until next version is out (which may be unspecified time in the future)? would there be higher chance if this expression was changed to build from github sources? I kinda miss Nim 1.4, and I wonder if there's a way I (or someone else) could help things advance... |
Seems like they haven't switched out the release tarball since I last checked a month ago, so we could probably go ahead with nim. I pushed the new hash to this branch. Still need to package nimble seperately. |
Can we leave |
After this change nimble isn't packaged at all. This would be very confusing to me as a user when I'm used to having nimble installed as part of the nim package. |
I think packaging nimble separately is momentarily confusing but inevitable. |
Actually not a problem, I will package nimble seperately from the unwrapped compiler and combine it into the wrapper. |
Build Nim with a second fixed-input hash for 1.4.0. The Nimble utility is no longer bundled with nim-unwrapped.
Motivation for this change
Nim 1.4.0 is out. This version was added at bb99a0d but reverted at bce139d when the source tarball was replaced. The new tarball no longer bundles the
nimble
utility (missing fromnim-unwrapped
), so this will need to be package seperately and included with thenim
package.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)