abseil-cpp: 20200225.2 -> 20200923.1 #100827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersk
suggested changes
Oct 18, 2020
There was a problem hiding this comment.
This breaks or-tools 7.7, so we should upgrade or-tools to 8.0 at the same time.
Cc maintainers of other packages that would break:
- @andir @flokli (google-cloud-cpp)
- @petabyteboy @infinisil (murmur)
- @ehmry @offlinehacker @RaghavSood (rippled)
|
The or-tools 8.0 release notes call out that or-tools now requires abseil-cpp to be built in C++17 mode, and I’ve empirically confirmed that this is needed. --- a/pkgs/development/libraries/abseil-cpp/default.nix
+++ b/pkgs/development/libraries/abseil-cpp/default.nix
@@ -13,6 +13,8 @@ stdenv.mkDerivation rec {
nativeBuildInputs = [ cmake ];
+ cmakeFlags = [ "-DCMAKE_CXX_STANDARD=17" ];
+
meta = with stdenv.lib; {
description = "An open-source collection of C++ code designed to augment the C++ standard library";
homepage = "https://abseil.io/";We’ll need to check if this will work for other abseil-cpp dependents, or if we need to make this a parameter… |
|
Thanks for catching that @andersk - I'll check on rippled today |
10 tasks
|
Replaced by #107846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/abseil/abseil-cpp/releases.
meta.description for abseil-cpp is: "An open-source collection of C++ code designed to augment the C++ standard library"
meta.homepage for abseil-cpp is: "https://abseil.io/"
meta.changelog for abseil-cpp is: ""
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 20200923.1 with grep in /nix/store/brrd48aksa2aqicgk6hii7y4z6zr9ic8-abseil-cpp-20200923.1
directory tree listing: https://gist.github.com/5abcac9c119897a899209ddb0865c6e8
du listing: https://gist.github.com/fa49345033b451ad1d2eb343f00c5c4e
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review18 packages failed to build:
24 packages built:
Maintainer pings
cc @andersk for testing.