Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libplacebo: Take out glslang patch not needed after #94049 #100825

Closed
wants to merge 1 commit into from
Closed

libplacebo: Take out glslang patch not needed after #94049 #100825

wants to merge 1 commit into from

Conversation

doronbehar
Copy link
Contributor

From some reason, if we take this patch out, libplacebo builds fine, and
mpv is again usable.

Motivation for this change

Make libplacebo build again after #94049.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
libplacebo: Take out glslang patch not needed after NixOS#94049
d8b5d9a 
From some reason, if we take this patch out, libplacebo builds fine, and
mpv is again usable.
@doronbehar doronbehar mentioned this pull request Oct 17, 2020
Merged
10 tasks
@doronbehar doronbehar closed this Oct 17, 2020
@doronbehar doronbehar deleted the pkg/libplacebo branch March 2, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@doronbehar