babashka,clj-kondo: Depend on graalvm-ce #102693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have community builds of graalvm landed in NixOS#99631, both clj-kondo and babashka can depend on those versions of graalvm rather than the one that requires building from source - this can be built in hydra, and generally is much easier to build and test.
bennyandresen
approved these changes
Nov 4, 2020
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
jlesquembre
approved these changes
Nov 4, 2020
77 tasks
jonringer
approved these changes
Nov 4, 2020
bennyandresen
added a commit
to bennyandresen/nixpkgs
that referenced
this pull request
Nov 5, 2020
with NixOS#99631 and NixOS#102693 merged, it's possible to bump the babashka version again. However recent versions of babashka depend on java11 features and I spoke in Slack with the project lead and this java11 dependency will exist going forward.
10 tasks
bennyandresen
added a commit
to bennyandresen/nixpkgs
that referenced
this pull request
Nov 11, 2020
with NixOS#99631 and NixOS#102693 merged, it's possible to bump the babashka version again. However recent versions of babashka depend on java11 features and I spoke in Slack with the project lead and this java11 dependency will exist going forward.
bennyandresen
added a commit
to bennyandresen/nixpkgs
that referenced
this pull request
Nov 11, 2020
with NixOS#99631 and NixOS#102693 merged, it's possible to bump the babashka version again. However recent versions of babashka depend on java11 features and I spoke in Slack with the project lead and this java11 dependency will exist going forward.
10 tasks
bennyandresen
added a commit
to bennyandresen/nixpkgs
that referenced
this pull request
Nov 12, 2020
with NixOS#99631 and NixOS#102693 merged, it's possible to bump the babashka version again. However recent versions of babashka depend on java11 features and I spoke in Slack with the project lead and this java11 dependency will exist going forward. (cherry picked from commit 172cbb8)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Now that we have community builds of graalvm landed in #99631, both
clj-kondo and babashka can depend on those versions of graalvm rather
than the one that requires building from source - this can be built in
hydra, and generally is much easier to build and test.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @hlolli @volth @bennyandresen