Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ungoogled-chromium: 85.0.4183.102-1 -> 86.0.4240.111-1 #102666

Merged
merged 1 commit into from Nov 5, 2020
Merged

ungoogled-chromium: 85.0.4183.102-1 -> 86.0.4240.111-1 #102666

merged 1 commit into from Nov 5, 2020

Conversation

squalus
Copy link
Member

@squalus squalus commented Nov 3, 2020

This updates ungoogled-chromium. This change was created by manually copying the regular chromium expressions and applying a small diff to support the ungoogled patchset.

Performed a cursory test and everything looks good.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @danielfullmer

ungoogled-chromium: 85.0.4183.102-1 -> 86.0.4240.111-1
744ea3d 
based on chromium master@26d3fbf2
@danielfullmer
Copy link
Contributor

Built and briefly tested on x86_64-linux. It'd be nice if ungoogled-software/ungoogled-chromium#1229 was merged so we could get the latest security fixes as well.

@squalus
Copy link
Member Author

squalus commented Nov 5, 2020

@primeos

primeos
primeos approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The diff LGTM.

I agree with @danielfullmer that an update to 86.0.4240.183 would also be nice.
@squalus I've also opened #102965 regarding this. IIRC you'd also prefer that, I think it would likely be better, and I guess we can even avoid the main drawbacks (the intention of the issue is that we discuss that first to avoid wasting time by changing anything and then deciding otherwise). I'd be happy to hear your opinion on that.

@primeos primeos merged commit 0e64b04 into NixOS:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@squalus @danielfullmer @primeos