Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klog: init at 1.3.2 #102669

Merged
merged 1 commit into from Jan 19, 2021
Merged

klog: init at 1.3.2 #102669

merged 1 commit into from Jan 19, 2021

Conversation

pulsation
Copy link
Contributor

Motivation for this change

KLog is a multiplatform free hamradio logger.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 4, 2020 •
edited

Result of nixpkgs-review pr 102669 run on x86_64-linux 1

1 package failed to build:
  • klog
configuring
QMAKEPATH=/nix/store/gnbsmzcp9n66vssz1sfv2yw26fd9xkb5-qtbase-5.15.0-dev:/nix/store/gnbsmzcp9n66vssz1sfv2yw26fd9xkb5-qtbase-5.15.0-dev:/nix/store/wacsr6pz13cvz7f6ih8v67yqj38sbvid-qtwayland-5.15.0-dev:/nix/store/wacsr6pz13cvz7f6ih8v67yqj38sbvid-qtwayland-5.15.0-dev:/nix/store/6vwwszsgsjnh794xfmbfacm5kk94ja2r-qtdeclarative-5.15.0-dev:/nix/store/6vwwszsgsjnh794xfmbfacm5kk94ja2r-qtdeclarative-5.15.0-dev:/nix/store/1rvchzwm3c96i1dikdx43h5d7krjhb1l-qtsvg-5.15.0-dev:/nix/store/1rvchzwm3c96i1dikdx43h5d7krjhb1l-qtsvg-5.15.0-dev:/nix/store/z4asv7pi13zwb5wif4ibirjp0i5xv4y4-qttools-5.15.0-dev:/nix/store/z4asv7pi13zwb5wif4ibirjp0i5xv4y4-qttools-5.15.0-dev:/nix/store/76j9qcdl6gl6bkcjqa1mn6b8ivdf9pd9-qtserialport-5.15.0-dev:/nix/store/76j9qcdl6gl6bkcjqa1mn6b8ivdf9pd9-qtserialport-5.15.0-dev:/nix/store/il1jq45yjkzmg1cgq3gcglybkdh32zh1-qtcharts-5.15.0-dev:/nix/store/il1jq45yjkzmg1cgq3gcglybkdh32zh1-qtcharts-5.15.0-dev
qmake PREFIX=/nix/store/7mhiy9a8hgi3accvwgd3h856ksin40mj-klog-1.3.2 NIX_OUTPUT_OUT=/nix/store/7mhiy9a8hgi3accvwgd3h856ksin40mj-klog-1.3.2 NIX_OUTPUT_DEV=/nix/store/7mhiy9a8hgi3accvwgd3h856ksin40mj-klog-1.3.2 NIX_OUTPUT_BIN=/nix/store/7mhiy9a8hgi3accvwgd3h856ksin40mj-klog-1.3.2 NIX_OUTPUT_DOC=/nix/store/7mhiy9a8hgi3accvwgd3h856ksin40mj-klog-1.3.2/share/doc/qt-5.15.0 NIX_OUTPUT_QML=/nix/store/7mhiy9a8hgi3accvwgd3h856ksin40mj-klog-1.3.2/lib/qt-5.15.0/qml NIX_OUTPUT_PLUGIN=/nix/store/7mhiy9a8hgi3accvwgd3h856ksin40mj-klog-1.3.2/lib/qt-5.15.0/plugins KLog.pro QMAKE_LRELEASE=/nix/store/z4asv7pi13zwb5wif4ibirjp0i5xv4y4-qttools-5.15.0-dev/bin/lrelease
Project ERROR: Cannot run compiler 'g++'. Output:
===================
===================
Maybe you forgot to setup the environment?

@pulsation pulsation marked this pull request as draft November 4, 2020 19:25
@pulsation
Copy link
Contributor Author

Hello @SuperSandro2000 , thanks for your review.

Sorry - unfortunately I couldn't reproduce the problem you encountered yet, so this PR will be marked as a draft for now. Here is the output of nixpkgs-review pr 102669 in case it could be useful : https://gist.github.com/pulsation/fe1c0967f545f783b909def7d7df6bd8

Some qt5 applications such as https://github.com/NixOS/nixpkgs/tree/master/pkgs/applications/editors/mindforger don't seem to require any special though, but I'll continue investigating.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102669 run on x86_64-linux 1

1 package built:
  • klog

@pulsation pulsation marked this pull request as ready for review November 6, 2020 11:05
@pulsation pulsation force-pushed the add-klog branch 2 times, most recently from 1a7ee0e to 6c3d6de Compare November 12, 2020 17:40
@roberth roberth changed the title Add klog klog: init at 1.3.2 Jan 19, 2021
roberth
roberth approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

@roberth roberth merged commit 33fdfd0 into NixOS:master Jan 19, 2021
@roberth
Copy link
Member

roberth commented Jan 19, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@roberth roberth roberth approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pulsation @SuperSandro2000 @roberth