mlc: init at 3.9 #102670
Merged
mlc: init at 3.9 #102670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkgs/tools/system/mlc/default.nix
Outdated
|
|
||
| nativeBuildInputs = [ patchelf ]; | ||
|
|
||
| phases = [ "unpackPhase" "installPhase" "patchPhase" ]; |
There was a problem hiding this comment.
Generally you shouldn't overwrite phases.
pkgs/tools/system/mlc/default.nix
Outdated
Comment on lines
19
to
20
| cp mlc $out/bin/mlc | ||
| chmod +x $out/bin/mlc |
There was a problem hiding this comment.
Suggested change
| cp mlc $out/bin/mlc | |
| chmod +x $out/bin/mlc | |
| install -Dm755 mlc $out/bin/ |
There was a problem hiding this comment.
Done. I also removed the mkdir $out/bin since that's handled by install as well.
pkgs/tools/system/mlc/default.nix
Outdated
| @@ -0,0 +1,34 @@ | |||
| { stdenv, fetchurl, patchelf, lib }: | |||
There was a problem hiding this comment.
Suggested change
| { stdenv, fetchurl, patchelf, lib }: | |
| { stdenv, fetchurl, patchelf }: |
You can use with stdenv;.
pkgs/tools/system/mlc/default.nix
Outdated
Comment on lines
27
to
33
| meta = { | ||
| homepage = "https://software.intel.com/content/www/us/en/develop/articles/intelr-memory-latency-checker.html"; | ||
| description = "Intel Memory Latency Checker"; | ||
| license = lib.licenses.unfree; | ||
| maintainers = with lib.maintainers; [ basvandijk ]; | ||
| platforms = with lib.platforms; linux; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| meta = { | |
| homepage = "https://software.intel.com/content/www/us/en/develop/articles/intelr-memory-latency-checker.html"; | |
| description = "Intel Memory Latency Checker"; | |
| license = lib.licenses.unfree; | |
| maintainers = with lib.maintainers; [ basvandijk ]; | |
| platforms = with lib.platforms; linux; | |
| }; | |
| meta = with stdenv.lib; { | |
| homepage = "https://software.intel.com/content/www/us/en/develop/articles/intelr-memory-latency-checker.html"; | |
| description = "Intel Memory Latency Checker"; | |
| license = licenses.unfree; | |
| maintainers = maintainers; [ basvandijk ]; | |
| platforms = with platforms; linux; | |
| }; |
|
@GrahamcOfBorg build mlc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://software.intel.com/content/www/us/en/develop/articles/intelr-memory-latency-checker.html
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)