Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.opam-file-format: 2.0.0 -> 2.1.0 #102671

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Nov 3, 2020

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ocaml4.10.0-opam-file-format/versions.

meta.description for ocamlPackages.opam-file-format is: "Parser and printer for the opam file syntax"

meta.homepage for ocamlPackages.opam-file-format is: "https://github.com/ocaml/opam-file-format"

meta.changelog for ocamlPackages.opam-file-format is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
183 total rebuild path(s)

50 package rebuild(s)

50 x86_64-linux rebuild(s)
47 i686-linux rebuild(s)
39 x86_64-darwin rebuild(s)
47 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
acgtk
alt-ergo
beluga
compcert
coqPackages.contribs.zorns-lemma
coq_8_10
coq_8_11
coq_8_12
dot-merlin-reader
dune
dune-release
eff
flow
framac
fstar
google-drive-ocamlfuse
jackline
libbap
libguestfs
liquidsoap
ocaml-crunch
ocaml-top
ocamlformat
ocamlformat_0_11_0
ocamlformat_0_12
ocamlformat_0_13_0
ocamlformat_0_14_0
ocamlformat_0_14_1
ocamlformat_0_14_2
ocamlformat_0_14_3
ocamlformat_0_15_0
ocsigen-i18n
opa
opaline
orpie
ott
patdiff
python27Packages.bap
python27Packages.guestfs
python37Packages.bap
python37Packages.guestfs
python38Packages.bap
python38Packages.guestfs
reason
satallax
satysfi
stog
vagrant
virt-top
why3
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/j5d35m13ngdwgz99v9a457p17hia5341-ocaml4.10.0-opam-file-format-2.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A ocamlPackages.opam-file-format https://github.com/r-ryantm/nixpkgs/archive/d45837128bfb0c50bfee62ea7f322e91bcf4e104.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/j5d35m13ngdwgz99v9a457p17hia5341-ocaml4.10.0-opam-file-format-2.1.0
ls -la /nix/store/j5d35m13ngdwgz99v9a457p17hia5341-ocaml4.10.0-opam-file-format-2.1.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review took longer than 45m and timed out


Maintainer pings

cc @vbgl for testing.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 4, 2020

Found while running nixpkgs-review:

W: Test 'main' fails: Command '/private/tmp/nix-build-ocaml4.07.1-fileutils-0.5.3.drv-0/ocaml-fileutils-0.5.3/_build/test/test.byte' terminated with error code 1
  E: Failure("Tests had a 100.00% failure rate")
  make: *** [Makefile:36: test] Error 1
builder for '/nix/store/xiydk16nkrwasil1pd9wwd084r3qkys8-ocaml4.10.0-gsl-1.24.3.drv' failed with exit code 1; last 10 log lines:
        ocamlc src/mlgsl_cdf.o
  clang-7: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
        ocamlc src/mlgsl_sf.o
  clang-7: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
    ocamlmklib src/dllgsl_stubs.so,src/libgsl_stubs.a (exit 2)
  (cd _build/default && /nix/store/mpzmisvbbr54g3f3jg54ag4kx55f77ya-ocaml-4.10.0/bin/ocamlmklib.opt -g -o src/gsl_stubs src/mlgsl_blas.o src/mlgsl_blas_complex.o src/mlgsl_blas_complex_float.o src/mlgsl_blas_float.o src/mlgsl_bspline.o src/mlgsl_cdf.o src/mlgsl_cheb.o src/mlgsl_combi.o src/mlgsl_complex.o src/mlgsl_deriv.o src/mlgsl_eigen.o src/mlgsl_error.o src/mlgsl_fft.o src/mlgsl_fit.o src/mlgsl_fun.o src/mlgsl_histo.o src/mlgsl_ieee.o src/mlgsl_integration.o src/mlgsl_interp.o src/mlgsl_linalg.o src/mlgsl_linalg_complex.o src/mlgsl_math.o src/mlgsl_matrix_complex.o src/mlgsl_matrix_complex_float.o src/mlgsl_matrix_double.o src/mlgsl_matrix_float.o src/mlgsl_min.o src/mlgsl_monte.o src/mlgsl_multifit.o src/mlgsl_multimin.o src/mlgsl_multiroots.o src/mlgsl_odeiv.o src/mlgsl_permut.o src/mlgsl_poly.o src/mlgsl_qrng.o src/mlgsl_randist.o src/mlgsl_rng.o src/mlgsl_roots.o src/mlgsl_sf.o src/mlgsl_sort.o src/mlgsl_stats.o src/mlgsl_sum.o src/mlgsl_vector_double.o src/mlgsl_vector_float.o src/mlgsl_wavelet.o -framework Accelerate -L/nix/store/6v6sy46gvd60rjx52m97b86a374c3irj-gsl-2.6/lib -lgsl -lm)
  ld: warning: passed two min versions (10.12.0, 10.12) for platform macOS. Using 10.12.
  ld: framework not found Accelerate
  clang-7: error: linker command failed with exit code 1 (use -v to see invocation)

Not sure which packages caused this error. When building all packages on their own this does not happen.

Edit: gsl is the failing package. Going to open another PR to fix that.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 4, 2020

Result of nixpkgs-review pr 102671 run on x86_64-darwin 1

4 packages marked as broken and skipped:
  • liquidsoap
  • python27Packages.guestfs
  • python37Packages.guestfs
  • python38Packages.guestfs
5 packages failed to build:
  • libbap
  • orpie
  • python27Packages.bap
  • python37Packages.bap
  • python38Packages.bap
29 packages built:
  • acgtk
  • alt-ergo
  • beluga
  • dot-merlin-reader
  • dune
  • dune-release
  • eff
  • flow
  • framac
  • fstar
  • jackline
  • ocaml-crunch
  • ocaml-top
  • ocamlformat (ocamlformat_0_15_0)
  • ocamlformat_0_11_0
  • ocamlformat_0_12
  • ocamlformat_0_13_0
  • ocamlformat_0_14_0
  • ocamlformat_0_14_1
  • ocamlformat_0_14_2
  • ocamlformat_0_14_3
  • opa
  • opaline
  • ott
  • patdiff
  • reason
  • satysfi
  • stog
  • why3

python3Packages.bap and libbap

==============================================================================
Error: ocaml-fileutils:1:FileUtil:0:Test.

File "/private/tmp/nix-build-ocaml4.07.1-fileutils-0.5.3.drv-0/ocaml-fileutils-0.5.3/_build/oUnit-ocaml-fileutils-oxygen.local#02.log", line 241, characters 1-1:
Error: ocaml-fileutils:1:FileUtil:0:Test (in the log).

Raised at file "src/lib/ounit2/advanced/oUnitAssert.ml", line 45, characters 8-27
Called from file "src/lib/ounit2/advanced/oUnitTest.ml", line 130, characters 16-22
Re-raised at file "src/lib/ounit2/advanced/oUnitTest.ml", line 135, characters 12-13
Called from file "src/lib/ounit2/advanced/oUnitTest.ml", line 267, characters 4-23

Test Is_owned_by_group_ID on /private/tmp/nix-build-ocaml4.07.1-fileutils-0.5.3.drv-0/ounit-c6fc0f-oxygen.local#02.dir
------------------------------------------------------------------------------
Ran: 257 tests in: 0.37 seconds.
FAILED: Cases: 257 Tried: 257 Errors: 0 Failures: 1 Skip:  0 Todo: 0 Timeouts: 0.
W: Test 'main' fails: Command '/private/tmp/nix-build-ocaml4.07.1-fileutils-0.5.3.drv-0/ocaml-fileutils-0.5.3/_build/test/test.byte' terminated with error code 1
E: Failure("Tests had a 100.00% failure rate")
make: *** [Makefile:36: test] Error 1
builder for '/nix/store/f250ip45alswmr3fwy0k4v3fj1q7wmzy-ocaml4.07.1-fileutils-0.5.3.drv' failed with exit code 2
cannot build derivation '/nix/store/6q21kp7s1k96k80yxyfiyi7gcjysr900-ocaml4.07.1-bap-2.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/r29r394kmziwing1jdxppkcm23bcsfg5-libbap-master-2019-11-15.drv': 1 dependencies couldn't be built
error: build of '/nix/store/r29r394kmziwing1jdxppkcm23bcsfg5-libbap-master-2019-11-15.drv' failed

orpie build fixed by #102814

@sternenseemann
Copy link
Member

nixpkgs-review build is fine on x86_64 NixOS, update LGTM.

@SuperSandro2000 can you test the failing packages on master? Maybe the build failure is unrelated to the update.

@SuperSandro2000
Copy link
Member

python3Packages.bap and libbap build fine on master but now something else fails. I think my builder is a bit flakey and not reliable for ocaml.

building
build flags: SHELL=/nix/store/7kzamk0abm530kkr5v106hnc3cfscwkc-bash-4.4-p23/bin/bash
ocamlbuild -use-ocamlfind opaline.native
/bin/sh: tput: command not found
+ ocamlfind ocamlopt -linkpkg -package unix,opam-file-format opaline.cmx -o opaline.native
File "_none_", line 1:
Error: No implementations provided for the following modules:
         OpamParser referenced from opaline.cmx
Command exited with code 2.
Compilation unsuccessful after building 4 targets (0 cached) in 00:00:00.
make: *** [Makefile:13: opaline.native] Error 10

@sternenseemann
Copy link
Member

Is that the build of libbap itself or of opaline?

@SuperSandro2000
Copy link
Member

Don't know anymore. Can't reproduce.

@vbgl
Copy link
Contributor

vbgl commented Dec 7, 2020

This PR is SPAM.

@vbgl vbgl closed this Dec 7, 2020
@r-ryantm r-ryantm deleted the auto-update/ocaml4.10.0-opam-file-format branch December 7, 2020 10:16
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 7, 2020

This PR is SPAM.

This is not true. @r-ryantm is our auto update bot which keeps packages up to date. Please do not call it spam. Thank you. This is especially true if maintainers like you do not keep their packages up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants