Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vim plugins and add LanguageTool.nvim #102657

Merged
merged 2 commits into from Nov 3, 2020
Merged

update vim plugins and add LanguageTool.nvim #102657

merged 2 commits into from Nov 3, 2020

Conversation

RonanMacF
Copy link
Contributor

@RonanMacF RonanMacF commented Nov 3, 2020 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/102657
22 packages built:
vimPlugins.LanguageTool-nvim vimPlugins.coc-explorer vimPlugins.coc-markdownlint vimPlugins.coc-nvim vimPlugins.defx-nvim vimPlugins.dracula-vim vimPlugins.float-preview-nvim vimPlugins.fzf-vim vimPlugins.kotlin-vim vimPlugins.neoformat vimPlugins.nvim-treesitter vimPlugins.tagbar vimPlugins.telescope-nvim vimPlugins.vim-clap vimPlugins.vim-dirdiff vimPlugins.vim-plug vimPlugins.vim-polyglot vimPlugins.vim-prosession vimPlugins.vim-qml vimPlugins.vim-snippets vimPlugins.vim-wakatime vimPlugins.vimsence

@jonringer jonringer merged commit 84884a4 into NixOS:master Nov 3, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102657 run on x86_64-darwin 1

1 package built:
  • vimPlugins.vim-clap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RonanMacF @SuperSandro2000 @jonringer