Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql: Fix timetz test failure #102659

Merged
merged 1 commit into from Nov 4, 2020
Merged

postgresql: Fix timetz test failure #102659

merged 1 commit into from Nov 4, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Nov 3, 2020 •
edited

A recent addition to the test suite turned out to be sensitive to
DST. The main code is ok. Patch only required to make test succeed.

See https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4a071afbd056282746a5bc9362e87f579a56402d

Motivation for this change

Unbreak unstable on next rebuild,
Unblock staging-20.09; will backport

Closes #102654

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @marsam @ocharles

@roberth roberth mentioned this pull request Nov 3, 2020
Closed
@roberth
postgresql: Fix timetz test failure
88f84e5 
A recent addition to the test suite turned out to be sensitive to
DST. The main code is ok. Patch only required to make test succeed.

See https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4a071afbd056282746a5bc9362e87f579a56402d
@roberth roberth force-pushed the postgresql-fix-timetz-test-failure branch from 09a59b3 to 88f84e5 Compare November 3, 2020 20:37
@FRidh FRidh added this to WIP in Staging via automation Nov 4, 2020
@FRidh FRidh merged commit 83163b4 into NixOS:staging-next Nov 4, 2020
Staging automation moved this from WIP to Done Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @FRidh