Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBT: Add test, update script, 1.4.0 -> 1.4.2 #102642

Merged
merged 3 commits into from Nov 4, 2020
Merged

SBT: Add test, update script, 1.4.0 -> 1.4.2 #102642

merged 3 commits into from Nov 4, 2020

Conversation

NeQuissimus
Copy link
Member

Motivation for this change
  • Update
  • Update script
  • Test
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus added 8.has: package (update) 6.topic: updaters Tooling for (semi-)automated updating of packages labels Nov 3, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102642 run on x86_64-linux 1

2 packages built:
  • sbt (simpleBuildTool)
  • sbt-with-scala-native

@NeQuissimus NeQuissimus marked this pull request as ready for review November 4, 2020 17:12
@NeQuissimus NeQuissimus merged commit ac9ba67 into NixOS:master Nov 4, 2020
@NeQuissimus NeQuissimus deleted the sbt_1_4_2 branch November 4, 2020 17:49
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102642 run on x86_64-darwin 1

2 packages built:
  • sbt (simpleBuildTool)
  • sbt-with-scala-native

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 6.topic: updaters Tooling for (semi-)automated updating of packages 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @SuperSandro2000