Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onlykey-cli: init 1.2.2 #102674

Merged
merged 2 commits into from Dec 28, 2020
Merged

onlykey-cli: init 1.2.2 #102674

merged 2 commits into from Dec 28, 2020

Conversation

ranfdev
Copy link
Contributor

@ranfdev ranfdev commented Nov 3, 2020 •
edited

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Nov 4, 2020
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/tools/security/onlykey-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/onlykey-cli/default.nix Show resolved Hide resolved
pkgs/tools/security/onlykey-cli/default.nix Outdated Show resolved Hide resolved
@ranfdev ranfdev mentioned this pull request Nov 12, 2020
Open
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102674 run on x86_64-linux 1

1 package built:
  • onlykey-cli

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102674 run on x86_64-darwin 1

1 package built:
  • onlykey-cli

@SuperSandro2000 SuperSandro2000 merged commit e1f445c into NixOS:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ranfdev @SuperSandro2000 @Janik-Haag