Hi, I recently started using Nix and adding the vala-language-server seemed like a useful first exercise. The default.nix file is loosely based on #83386. I did my best to match the CONTRIBUTING.md. For now I added myself as only maintainer, but as I am a new user, I am unsure if I can guarantee to maintain it. So maybe someone else wants to add themselves to the maintainers list?

Oh hi @andreasfelix, I recall some of your contributions in the elementary community. Cool to see u here, I maintain pantheon and vala here.

So maybe someone else wants to add themselves to the maintainers list?

Feel free to add me, I wasn't really sure if gvls or vala-language-server was going to be defacto or something (like will Code use this one day).
You can also add the following to the expression to get semi-automatic updates

passthru = {
  updateScript = nix-update-script {
    attrPath = pname;
  };
}

and you can run

nix-shell maintainers/scripts/update.nix --argstr maintainer andreasfelix  --argstr commit true

and it will make a commit for you if there's a change upstream. See also https://nixos.org/manual/nixpkgs/stable/#ssec-stdenv-attributes passthru.updateScript

Result of nixpkgs-review pr 102664 run on x86_64-linux 1

Found ninja-1.10.1 at /nix/store/ba77flp1iya22w2v7yih1vwz8z4zwdnb-ninja-1.10.1/bin/ninja
Using 'STRIP' from environment with value: 'strip'
Using 'STRIP' from environment with value: 'strip'
meson: enabled parallel building
@nix { "action": "setPhase", "phase": "buildPhase" }
building
build flags: -j8 -l8
^M[0/34] Generating vala-language-server.1 with a custom commandninja: fatal: posix_spawn: No such file or directory

Result of nixpkgs-review pr 102664 run on x86_64-linux 1
1 package failed to build:

Found ninja-1.10.1 at /nix/store/ba77flp1iya22w2v7yih1vwz8z4zwdnb-ninja-1.10.1/bin/ninja
Using 'STRIP' from environment with value: 'strip'
Using 'STRIP' from environment with value: 'strip'
meson: enabled parallel building
@nix { "action": "setPhase", "phase": "buildPhase" }
building
build flags: -j8 -l8
^M[0/34] Generating vala-language-server.1 with a custom commandninja: fatal: posix_spawn: No such file or directory

Interesting, it passed on ofborg. Will try to reproduce

gnome-builder support would be cool

I looked at the installed output and there's a plugin. But it assumes ABI is 3.38, so we'd need to add those dependencies.

As for the nixpkgs-review result, I can't reproduce

Oh hi @andreasfelix, I recall some of your contributions in the elementary community. Cool to see u here, I maintain pantheon and vala here.

Yeees, hi there 👋 Thanks for the fast and detailed reply!

I incorporate your suggestion with the update script and also added you as additional maintainer.

gnome-builder support would be cool

done

It adds the following native dependencies https://github.com/benwaffle/vala-language-server/blob/master/plugins/gnome-builder/meson.build#L7

Is it save to assume that sh is available? I added the dash shell dependency for now.

Result of nixpkgs-review pr 102664 run on x86_64-linux 1

done

Thx for contributing @andreasfelix ✨