Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libhandy: 0.0.13 -> 1.0.1 #102678

Closed
wants to merge 1 commit into from
Closed

libhandy: 0.0.13 -> 1.0.1 #102678

wants to merge 1 commit into from

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented Nov 4, 2020 •
edited

Motivation for this change

Project became a proper GNOME project, version updated and URL changed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 102678"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jtojnar November 4, 2020 00:39
@worldofpeace
Copy link
Contributor

We already have this in staging, this on its own without many changes would cause major breakage

@omasanori
Copy link
Contributor

Result of nixpkgs-review pr 102678 1

31 packages failed to build:
  • adapta-gtk-theme
  • calls
  • chrome-gnome-shell
  • contrast
  • deja-dup
  • epiphany (gnome3.epiphany)
  • fractal
  • gnome-passwordsafe
  • gnome-podcasts
  • gnome3.bijiben (gnome3.gnome-notes)
  • gnome3.geary
  • gnome3.gnome-calendar
  • gnome3.gnome-clocks
  • gnome3.gnome-control-center (gnome3.gnome_control_center)
  • gnome3.gnome-session (gnome3.gnome_session)
  • gnome3.gnome-shell (gnome3.gnome_shell)
  • gnome3.gnome-terminal (gnome3.gnome_terminal)
  • gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
  • gnome3.pomodoro
  • gnome3.seahorse
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • newsflash
  • pantheon.appcenter
  • pantheon.elementary-greeter
  • pantheon.elementary-gsettings-schemas
  • pantheon.elementary-onboarding
  • pantheon.elementary-session-settings
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-with-indicators
  • shortwave
2 packages built:
  • gnome3.gnome-contacts
  • libhandy

@worldofpeace
Copy link
Contributor

Yeah, and all of those breakages have already been fixed in staging. We had some issues with staging so it's taken longer than usual

@wamserma
Copy link
Member Author

wamserma commented Nov 4, 2020

@worldofpeace Ah, I had missed the PR was to staging (just saw that the Gnome 3.38 was merged and somehow assumed it was to master where this update was missing). Good to know I don't have to fix all the breakage on my own.

w.r.t. to the above PR, this bumps the version to current (one minor release) and fixes the checkPhase - shall I retarget this to staging or wait until it has landed in master? If so, should librsvg go to the propagatedBuildInputs?

@wamserma
Copy link
Member Author

wamserma commented Nov 4, 2020

shall I retarget this to staging

Done here: #102752

@wamserma wamserma deleted the libhandy-101 branch November 4, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @worldofpeace @omasanori