Skip to content

i3status-rust: add missing ethtool and notmuch buildInputs #102679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

i3status-rust: add missing ethtool and notmuch buildInputs #102679

merged 1 commit into from
Nov 4, 2020
+20 −3

Conversation

andir
Copy link
Member

@andir andir commented Nov 4, 2020

Motivation for this change

i3status-rust requires ethtool for the net block to work since 0.14.2.
The notmuch feature is also available and all we've to do for that is to
pass the notmuch input and enable the feature.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)

cc @Ma27

Sorry, something went wrong.

@andir
i3status-rust: add missing ethtool and notmuch buildInputs

Verified

This commit was signed with the committer’s verified signature.
kurtmckee Kurt McKee
GPG key ID: 64713C0B5BA8E1C2
Verified
Learn about vigilant mode
c347482 
i3status-rust requires `ethtool` for the net block to work since 0.14.2.
The notmuch feature is also available and all we've to do for that is to
pass the `notmuch` input and enable the feature.
@andir andir requested a review from Moredread November 4, 2020 00:17
@ofborg ofborg bot requested review from globin and Ma27 November 4, 2020 00:32
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 4, 2020
jonringer
jonringer approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102679 1

1 package built:
  • i3status-rust

@jonringer jonringer merged commit db530f4 into NixOS:master Nov 4, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 4, 2020 •
edited
Loading

Result of nixpkgs-review pr 102679 run on x86_64-linux 1

1 package failed to build:
  • i3status-rust
   PASS   Show message: json --body=false                                                                                      PASS   Search message: json                                                                                                 PASS   Show message: json, utf-8                                                                                           FATAL: /build/notmuch/test/T160-json.sh: interrupted by signal 15                                                                                                                                                                                       Notmuch test suite complete.
  311/317 tests passed.
  6 tests failed.
  ERROR: Aborting on T160-json (returned 124)
  make: *** [test/Makefile.local:75: test] Error 1
cannot build derivation '/nix/store/b4vbvkd48wbl0nis8mi0lbm5a0l1qm1j-i3status-rust-0.14.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xdad5vh44f8xz9n0kgf3658w4cqk6xw2-env.drv': 1 dependencies couldn't be built

Sadly it failed to pull the entire error log.

edit:

notmuch fails to build with test errros:

FAIL   Show, default exclusion
        --- T140-excludes.41.expected   2020-11-04 15:44:46.015292690 +0000
        +++ T140-excludes.41.output     2020-11-04 15:44:46.015292690 +0000
        @@ -1,4 +1 @@
        -
         message{ id:XXXXX depth:0 match:1 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 4
        -
         message{ id:XXXXX depth:0 match:1 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 3
        +
/build/notmuch/test/T140-excludes.sh: /nix/store/8kv1647yhqd13z571h56rgm2ldm567dm-gnugrep-3.5/bin/egrep: /bin/sh: bad interpreter: No such file or directory
sed: couldn't flush stdout: Broken pipe

 FAIL   Show, default exclusion (entire-thread)                                                                                     --- T140-excludes.42.expected   2020-11-04 15:44:46.027292766 +0000                                                         +++ T140-excludes.42.output     2020-11-04 15:44:46.027292766 +0000                                                         @@ -1,24 +1 @@                                                                                                              -                                                                                                                            message{ id:XXXXX depth:0 match:0 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: top message
        -
         message{ id:XXXXX depth:1 match:0 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 1
        -
         message{ id:XXXXX depth:2 match:0 excluded:1 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 2
        -
         message{ id:XXXXX depth:3 match:0 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 3
        -
         message{ id:XXXXX depth:4 match:1 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 4
        -
         message{ id:XXXXX depth:5 match:0 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 5
        -
         message{ id:XXXXX depth:0 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: top message
        -
         message{ id:XXXXX depth:1 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 1
        -
         message{ id:XXXXX depth:2 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 2
        -
         message{ id:XXXXX depth:3 match:1 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 3
        -
         message{ id:XXXXX depth:4 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 4
        -
         message{ id:XXXXX depth:5 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 5
        -Subject: No messages excluded: single match: reply 5                                                    [200/30154]        +
/build/notmuch/test/T140-excludes.sh: /nix/store/8kv1647yhqd13z571h56rgm2ldm567dm-gnugrep-3.5/bin/egrep: /bin/sh: bad interpreter: No such file or directory
sed: couldn't write 52 items to stdout: Broken pipe
 FAIL   Show, exclude=true
        --- T140-excludes.43.expected   2020-11-04 15:44:46.039292841 +0000
        +++ T140-excludes.43.output     2020-11-04 15:44:46.039292841 +0000
        @@ -1,4 +1 @@
        -
         message{ id:XXXXX depth:0 match:1 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 4
        -
         message{ id:XXXXX depth:0 match:1 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 3
        +
/build/notmuch/test/T140-excludes.sh: /nix/store/8kv1647yhqd13z571h56rgm2ldm567dm-gnugrep-3.5/bin/egrep: /bin/sh: bad interpreter: No such file or directory
sed: couldn't flush stdout: Broken pipe
 FAIL   Show, exclude=true (entire-thread)
        --- T140-excludes.44.expected   2020-11-04 15:44:46.051292916 +0000
        +++ T140-excludes.44.output     2020-11-04 15:44:46.051292916 +0000
        @@ -1,24 +1 @@
        -
         message{ id:XXXXX depth:0 match:0 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: top message
        -
         message{ id:XXXXX depth:1 match:0 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 1
        -
         message{ id:XXXXX depth:2 match:0 excluded:1 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 2
        -
         message{ id:XXXXX depth:3 match:0 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 3
        -
         message{ id:XXXXX depth:4 match:1 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 4
        -
         message{ id:XXXXX depth:5 match:0 excluded:0 filename:XXXXX
        -Subject: Some messages excluded: single non-excluded match: reply 5
        -
         message{ id:XXXXX depth:0 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: top message
        -
         message{ id:XXXXX depth:1 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 1
        -
         message{ id:XXXXX depth:2 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 2
        -
         message{ id:XXXXX depth:3 match:1 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 3
        -
         message{ id:XXXXX depth:4 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 4
        -
         message{ id:XXXXX depth:5 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 5
        +
/build/notmuch/test/T140-excludes.sh: /nix/store/8kv1647yhqd13z571h56rgm2ldm567dm-gnugrep-3.5/bin/egrep: /bin/sh: bad interpreter: No such file or directory
sed: couldn't write 52 items to stdout: Broken pipe
 FAIL   Show, exclude=false
        --- T140-excludes.45.expected   2020-11-04 15:44:46.063292991 +0000
        +++ T140-excludes.45.output     2020-11-04 15:44:46.063292991 +0000
        @@ -1,12 +1 @@
        -
         message{ id:XXXXX depth:0 match:1 excluded:1 filename:XXXXX
        -Subject: All messages excluded: single match: reply 2
        -
         message{ id:XXXXX depth:0 match:1 excluded:1 filename:XXXXX
        -Subject: All messages excluded: double match: reply 2
        -
         message{ id:XXXXX depth:1 match:1 excluded:1 filename:XXXXX
        -Subject: All messages excluded: double match: reply 4
        -
         message{ id:XXXXX depth:0 match:1 excluded:1 filename:XXXXX
        -Subject: Some messages excluded: single excluded match: reply 3
         message{ id:XXXXX depth:0 match:1 excluded:0 filename:XXXXX                                             [120/30154]        -Subject: Some messages excluded: single non-excluded match: reply 4
        -
         message{ id:XXXXX depth:0 match:1 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 3
        +
/build/notmuch/test/T140-excludes.sh: /nix/store/8kv1647yhqd13z571h56rgm2ldm567dm-gnugrep-3.5/bin/egrep: /bin/sh: bad interpreter: No such file or directory
sed: couldn't flush stdout: Broken pipe
 FAIL   Show, exclude=false (entire-thread)
        --- T140-excludes.46.expected   2020-11-04 15:44:46.075293065 +0000
        +++ T140-excludes.46.output     2020-11-04 15:44:46.075293065 +0000
        @@ -1,60 +1 @@
        -
         message{ id:XXXXX depth:0 match:0 excluded:1 filename:XXXXX
        -Subject: All messages excluded: single match: top message
        -
         message{ id:XXXXX depth:1 match:0 excluded:1 filename:XXXXX
        -Subject: All messages excluded: single match: reply 1
        -
         message{ id:XXXXX depth:2 match:1 excluded:1 filename:XXXXX
        -Subject: All messages excluded: single match: reply 2
        -
         message{ id:XXXXX depth:3 match:0 excluded:1 filename:XXXXX
        -Subject: All messages excluded: single match: reply 3
        -
         message{ id:XXXXX depth:4 match:0 excluded:1 filename:XXXXX
        -Subject: All messages excluded: single match: reply 4
        -
         message{ id:XXXXX depth:5 match:0 excluded:1 filename:XXXXX
        -Subject: All messages excluded: single match: reply 5
        -
         message{ id:XXXXX depth:0 match:0 excluded:1 filename:XXXXX
        -Subject: All messages excluded: double match: top message
        -
         message{ id:XXXXX depth:1 match:0 excluded:1 filename:XXXXX
        -Subject: All messages excluded: double match: reply 1
        -
         message{ id:XXXXX depth:2 match:1 excluded:1 filename:XXXXX
        -Subject: All messages excluded: double match: reply 2
...
         message{ id:XXXXX depth:3 match:1 excluded:0 filename:XXXXX                                              [25/30154]        -Subject: No messages excluded: single match: reply 3
        -
         message{ id:XXXXX depth:4 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 4
        -
         message{ id:XXXXX depth:5 match:0 excluded:0 filename:XXXXX
        -Subject: No messages excluded: single match: reply 5
        +
/build/notmuch/test/T140-excludes.sh: /nix/store/8kv1647yhqd13z571h56rgm2ldm567dm-gnugrep-3.5/bin/egrep: /bin/sh: bad interpreter: No such file or directory
sed: couldn't write 53 items to stdout: Broken pipe
sed: couldn't write 80 items to stdout: Broken pipe

@andir
Copy link
Member Author

andir commented Nov 5, 2020

@SuperSandro2000 that is an unrelated change. The errors you are seeing appear to come from notmuch and not from i3status-rust.

@pacien pacien mentioned this pull request Nov 9, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@Moredread Moredread

@globin globin

@Ma27 Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @SuperSandro2000 @jonringer