Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coconut: init at 1.4.3 #102675

Merged
merged 3 commits into from Nov 10, 2020
Merged

coconut: init at 1.4.3 #102675

merged 3 commits into from Nov 10, 2020

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Nov 3, 2020 •
edited

Add Coconut interpreter.

Includes a patch that affected building: evhub/coconut#560

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Nov 4, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you are the module in the top level file python-packages.nix and the application in all-packages.nix.

pkgs/development/python-modules/cPyparsing/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cPyparsing/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cPyparsing/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/coconut/default.nix Show resolved Hide resolved
@fabianhjr fabianhjr force-pushed the add-coconut branch 6 times, most recently from efaa65b to 9d093a1 Compare November 4, 2020 02:31
jonringer
jonringer reviewed Nov 4, 2020
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/python-modules/cPyparsing/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cPyparsing/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@fabianhjr fabianhjr force-pushed the add-coconut branch 2 times, most recently from 451d34f to d275c2f Compare November 4, 2020 05:23
@fabianhjr
Copy link
Member Author

Thanks for your review @jonringer, I have applied all the corrections you pointed out, rebuilt locally, and retested the binary in NixOS.

@fabianhjr
Copy link
Member Author

fabianhjr commented Nov 4, 2020 •
edited

Ok, changed to fetch from github instead of PyPI, though I am having an issue with the coconut test-suite where it doesn't find the 'coconut' binary it just built in some tests and some tests attempt to fetch external resources via git

E AssertionError: Return code not as expected (128 != 0) in: ['git', 'clone', 'https://github.com/evhub/pyston.git']
E AssertionError: Return code not as expected (128 != 0) in: ['git', 'clone', 'https://github.com/evhub/pyprover.git']
E AssertionError: Return code not as expected (128 != 0) in: ['git', 'clone', 'https://github.com/evhub/coconut-prelude']

@fabianhjr fabianhjr force-pushed the add-coconut branch 2 times, most recently from 9328162 to 920c05b Compare November 4, 2020 07:13
@fabianhjr
Copy link
Member Author

Enabled passing tests only

@jonringer
Copy link
Contributor

yea, tests which do impure things like doing git commands, should be deselected.

Really, we just want to make sure that the package is usable at runtime and there's not any assumptions broken. E.g. shell commands not working /bin/bash, or version incompatibilities with dependencies.

jonringer
jonringer reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/cpyparsing/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cpyparsing/default.nix Outdated Show resolved Hide resolved
@fabianhjr
Copy link
Member Author

Applied your last 2 suggestions, thanks for the help.

@fabianhjr
Copy link
Member Author

Hi, just bumping this PR.

jonringer
jonringer approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102675 1

5 packages built:
  • coconut (python38Packages.coconut)
  • python27Packages.cpyparsing
  • python37Packages.coconut
  • python37Packages.cpyparsing
  • python38Packages.cpyparsing

@jonringer jonringer merged commit 674d77e into NixOS:master Nov 10, 2020
@fabianhjr fabianhjr deleted the add-coconut branch November 10, 2020 07:38
@fabianhjr
Copy link
Member Author

Thanks for reviewing, merging, and more generally maintaining Nixpkgs. uwu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabianhjr @jonringer @SuperSandro2000