Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.shellFor: add a doBenchmark argument for enabling benchmark deps #102683

Merged
merged 1 commit into from Nov 5, 2020
Merged

haskellPackages.shellFor: add a doBenchmark argument for enabling benchmark deps #102683

merged 1 commit into from Nov 5, 2020

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 4, 2020 •
edited

Motivation for this change

Add a doBenchmark argument for enabling benchmark deps when creating a development shell with shellFor.

This is necessary for users that want to make sure shellFor creates a package database with benchmark-specific libraries (like criterion).

cc @maralorn @peti @harendra-kumar

This supercedes #102323.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build tests.haskell-shellFor

I've confirmed locally that the hash for tests.haskell-shellFor doesn't change with the introduction of this PR. That's a good indication that this PR at least won't affect any current users negatively.

I've also tested it against the example in #102323 (comment), and it appears to correctly give benchmark deps.

@harendra-kumar harendra-kumar mentioned this pull request Nov 4, 2020
Closed
10 tasks
@maralorn
Copy link
Member

maralorn commented Nov 4, 2020

I haven‘t tested it, but this looks totally reasonable.

@cdepillabout
Copy link
Member Author

Thanks for the review!

@cdepillabout cdepillabout merged commit 1d8685a into NixOS:haskell-updates Nov 5, 2020
@cdepillabout cdepillabout deleted the shellFor-add-benchmark branch February 3, 2021 02:36
@cdepillabout cdepillabout mentioned this pull request Feb 3, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harendra-kumar harendra-kumar harendra-kumar approved these changes

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdepillabout @maralorn @harendra-kumar