eval: partially split up github interactions #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
force-pushed
the
eval-repo-client
branch
from
5f72056
to
685fd94
Compare
cole-h
approved these changes
Nov 5, 2020
LnL7
force-pushed
the
eval-repo-client
branch
from
c5386e4
to
6d6fb0f
Compare
|
@cole-h This is pretty much everything that doesn't spill over into other parts of the code. Doesn't really matter to me to keep working in small chunks on a branch or merge them in one by one. |
|
I personally think it might be better to merge them all at once, if you're fine with that. The split doesn't (or shouldn't) impact anything functionality-wise, so I don't think there's a need to merge the little changes "ASAP". |
LnL7
force-pushed
the
eval-repo-client
branch
from
2ccdab7
to
765ca8e
Compare
LnL7
force-pushed
the
eval-repo-client
branch
from
765ca8e
to
f5c65fc
Compare
cole-h
approved these changes
Nov 24, 2020
ofborg/src/tasks/evaluate.rs
Outdated
| @@ -495,8 +499,8 @@ fn schedule_builds( | |||
| response | |||
| } | |||
|
|
|||
| pub fn make_gist<'a>( | |||
| gists: &hubcaps::gists::Gists<'a>, | |||
| pub fn make_gist( | |||
There was a problem hiding this comment.
Any reason to not make this a method on the Client trait that takes an &self?
| for maintainer in maint.maintainers() { | ||
| if let Ok(meta) = &pull_meta { | ||
| fn request_reviews( | ||
| repo_client: &dyn ghrepo::Client, |
There was a problem hiding this comment.
Same here, any reason not to make this a trait method for Client?
LnL7
force-pushed
the
eval-repo-client
branch
from
1694f41
to
5ffedd6
Compare
LnL7
force-pushed
the
eval-repo-client
branch
from
5ffedd6
to
1886b2d
Compare
LnL7
force-pushed
the
eval-repo-client
branch
from
1886b2d
to
71ed184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.