Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt: 3002 -> 3002.1 #102643

Merged
merged 1 commit into from Nov 3, 2020
Merged

salt: 3002 -> 3002.1 #102643

merged 1 commit into from Nov 3, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 3, 2020

Motivation for this change

https://www.saltstack.com/blog/on-november-3-2020-saltstack-publicly-disclosed-three-new-cves/

Fixes: CVE-2020-16846, CVE-2020-17490, CVE-2020-25592

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested a review from Flakebi November 3, 2020 18:06
@mweinelt mweinelt changed the title salt: 3002 -> 3002.1 WIP: salt: 3002 -> 3002.1 Nov 3, 2020
@mweinelt mweinelt changed the title WIP: salt: 3002 -> 3002.1 salt: 3002 -> 3002.1 Nov 3, 2020
@mweinelt
Copy link
Member Author

mweinelt commented Nov 3, 2020

I went to their IRC to get confirmation, that 3002.1 (tagged 8d ago) contains the security fixes.

@andir andir merged commit 8222839 into NixOS:master Nov 3, 2020
@mweinelt mweinelt deleted the salt branch November 3, 2020 18:42
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 4, 2020 •
edited

Result of nixpkgs-review pr 102643 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • pepper
1 package failed to build:
  • salt
ERROR: Could not find a version that satisfies the requirement pyobjc-framework-pushkit==6.2.2 (from salt==3002.1) (from versions: none)
ERROR: No matching distribution found for pyobjc-framework-pushkit==6.2.2 (from salt==3002.1)

Can be fixed with #102306

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 4, 2020
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Awaiting requested review from Flakebi

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @SuperSandro2000 @andir