Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxPlugins.vim-tmux-focus-events: init at unstable 2010-10-06 #102661

Merged
merged 1 commit into from Nov 26, 2020
Merged

tmuxPlugins.vim-tmux-focus-events: init at unstable 2010-10-06 #102661

merged 1 commit into from Nov 26, 2020

Conversation

RonanMacF
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash the commits together?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102661 run on x86_64-linux 1

1 package built:
  • tmuxPlugins.vim-tmux-focus-events

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102661 run on x86_64-darwin 1

1 package built:
  • tmuxPlugins.vim-tmux-focus-events

@RonanMacF
Copy link
Contributor Author

Can you please squash the commits together?

done

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102661 run on x86_64-linux 1

1 package built:
  • tmuxPlugins.vim-tmux-focus-events

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102661 run on x86_64-darwin 1

1 package built:
  • tmuxPlugins.vim-tmux-focus-events

@SuperSandro2000 SuperSandro2000 merged commit 94d0229 into NixOS:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RonanMacF @SuperSandro2000