Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt: 3001.1 -> 3002 and change maintainer #101480

Merged
merged 2 commits into from Oct 23, 2020
Merged

salt: 3001.1 -> 3002 and change maintainer #101480

merged 2 commits into from Oct 23, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Oct 23, 2020

Motivation for this change

Salt v3002 got released: https://docs.saltstack.com/en/latest/topics/releases/3002.html
Also, remove @aneeshusa as maintainer and add myself instead as already done in #99060. (cc @doronbehar)

Things done

Checked that a salt master and minion work.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endocrimes
Copy link
Member

Result of nixpkgs-review pr 101480 1

1 package marked as broken and skipped:
  • pepper
1 package built:
  • salt

endocrimes
endocrimes approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for taking this over 👍 ✨

@doronbehar doronbehar merged commit c904500 into NixOS:master Oct 23, 2020
@Flakebi Flakebi deleted the salt branch October 24, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flakebi @endocrimes @doronbehar