Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluffychat: init at v0.20.0 [major wip] #101514

Closed
wants to merge 1 commit into from

Conversation

colemickens
Copy link
Member

Motivation for this change

Fixes #101111. Major WIP. I don't think there's any Flutter packages in tree, I think due to SDK freedom issues. (Another case where getting some things from Robotnix into nixpkgs might be useful? Or a new "flake-flutter" or "flake-android" with these tools available?)

status: probably not even close to building, probably needs someone familiar with Flutter to help fix this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

, ninja
, pkgconfig
, gtk3
, flutter, dart, android-studio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, flutter, dart, android-studio
, flutter
, dart
, android-studio

, cmake
, utillinux
, ninja
, pkgconfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, pkgconfig
, pkg-config

{ stdenv
, fetchFromGitLab
, cmake
, utillinux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, utillinux
, util-linux

Comment on lines +24 to +31
nativeBuildInputs = [
cmake
ninja
pkgconfig
flutter dart android-studio

utillinux
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [
cmake
ninja
pkgconfig
flutter dart android-studio
utillinux
];
nativeBuildInputs = [
cmake
ninja
pkg-config
flutter
dart
android-studio
util-linux
];

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@mkg20001
Copy link
Member

I'll try to get this packaged as part of #147107

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 23, 2021
@mkg20001
Copy link
Member

Superseeded by #147107

@mkg20001 mkg20001 closed this Feb 19, 2022
@colemickens colemickens deleted the fluffychat branch December 30, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fluffychat: flutter-based Matrix client
3 participants