Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iozone: 3.471 -> 3.490 #101495

Merged
merged 1 commit into from Oct 24, 2020
Merged

iozone: 3.471 -> 3.490 #101495

merged 1 commit into from Oct 24, 2020

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Oct 23, 2020

Motivation for this change

update iozone to latest upstream
generate url instead of hardcoding the version in the url
this should make auto-updating possible via nixpkgs-update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

generate url instead of hardcoding the version in the url
this should make auto-updating possible via nixpkgs-update
@makefu
Copy link
Contributor Author

makefu commented Oct 23, 2020

@GrahamcOfBorg build iozone

Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review on macos 10.14

@Lassulus Lassulus merged commit 49701c3 into NixOS:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants