Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

birdtray: 1.8.1 -> 1.9.0 #101483

Merged
merged 1 commit into from Oct 24, 2020
Merged

birdtray: 1.8.1 -> 1.9.0 #101483

merged 1 commit into from Oct 24, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Oct 23, 2020

Motivation for this change

Birdtray 1.9.0 was release: https://github.com/gyunaev/birdtray/releases/tag/v1.9.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endocrimes
Copy link
Member

Result of nixpkgs-review pr 101483 1

1 package built:
  • birdtray

@endocrimes
Copy link
Member

Result of nixpkgs-review pr 101483 1

1 package built:
  • birdtray

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/261

@danieldk danieldk merged commit 793a236 into NixOS:master Oct 24, 2020
@Flakebi Flakebi deleted the birdtray branch October 25, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Flakebi @endocrimes @nixos-discourse @danieldk