Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] wasmtime: 0.19.0 -> 0.20.0 #101499

Closed
wants to merge 1 commit into from
Closed

[20.09] wasmtime: 0.19.0 -> 0.20.0 #101499

wants to merge 1 commit into from

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Oct 23, 2020 •
edited

(cherry picked from commit 0243a18)

Motivation for this change

Backport of #99946.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif
wasmtime: 0.19.0 -> 0.20.0
5211ef4 
(cherry picked from commit 0243a18)
@ggreif
Copy link
Contributor Author

ggreif commented Oct 23, 2020

@GrahamcOfBorg build wasmtime

@ggreif ggreif marked this pull request as ready for review October 23, 2020 21:00
@ggreif ggreif mentioned this pull request Oct 23, 2020
Merged
@ofborg ofborg bot requested a review from matthewbauer October 23, 2020 21:14
@ggreif
Copy link
Contributor Author

ggreif commented Oct 26, 2020

Looks like 0.20.0 has a stack unwinding bug. Let's be conservative here.

@ggreif ggreif closed this Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ggreif