New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk15-bootstrap: fix i686 build #101474
Conversation
Just tried to build this via
|
That's strange. I did a rebuild of $ nix build --no-link --rebuild /nix/store/k1a4cb64ym78ykx3hgm52nmlkvxdp3fw-openjdk-headless-13.0.2-ga.drv
error: --- Error -------------------------------------------------------------------- nix
derivation '/nix/store/k1a4cb64ym78ykx3hgm52nmlkvxdp3fw-openjdk-headless-13.0.2-ga.drv' may not be deterministic: output '/nix/store/i8ic64dd5b3318n0jkr064gpap5z90sp-openjdk-headless-13.0.2-ga-debug' differs k1a4cb64ym78ykx3hgm52nmlkvxdp3fw-openjdk-headless-13.0.2-ga.drv.log |
OpenJDK 14 is no longer in nixpkgs unstable. Is this still required for other newer versions of openjdk, maybe? |
14e6627
to
be4763a
Compare
Yes, this is still needed. The tests mentioned above are still failing. I took another go at building the packages and now also got similar segfaults as @andir. The issue seems to be the used gcc version. I tried it with gcc 8, 9 and 10, and only the gcc8 build succeeds. When looking at the Debian build of @andir Can you please try to build the new version with gcc8 again? |
Thank you for the update! FWIW, here is how things eventually fail here (x86_64 system), running
So it actually fails building openjdk11. Maybe openjdk11 would require the same gcc8 override? That said, it could maybe also be due to my computer not having enough RAM to compile openjdk… though I haven't seen an OOM message in my logs so that'd be surprising. Do you know of an x86_64 system where the above-listed nix-build command works? |
Just noticed that I missed the
With that commit in place your build command is fine and builds all jdks for me: $ nix-build -E 'let pkgs = import ./. { overlays = []; }; in pkgs.pkgsi686Linux.openjdk15'
/nix/store/nryhys2rsqnfr8s4qix68z4pl64qfqc5-openjdk-15.0.1-ga
Your build log does not mention any compile errors in it's output. The segfaults I was getting are reported pretty clearly, like the error log above. So the build build might have been killed/died due to resource exhaustion (disk space, RAM). I tested the
So I'm not sure what caused the build to fail for you 🤔 |
Cool, thank you for your feedback! I'd say it's probably just my computer not having enough RAM indeed… let's try to build on ofborg instead :) @ofborg build pkgsi686Linux.openjdk15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, r+ing the changes as they currently are, hoping that ofborg can confirm this is green to land
Looks like ofborg successfully built it! Merging this PR, thank you :) |
Motivation for this change
The following tests are currently blocked, because
openjdk14
fail to build oni686-linux
:This happens because of an incompatibility of older openjdk versions used during bootstrap with
gmumake-4.3
( upstream issue ). Newer version of openjdk already include the used patch.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)