fiche: init at version 0.9.1 #101469
fiche: init at version 0.9.1 #101469
Conversation
pinpox
changed the title
|
The package builds and works fine now on my machine. |
|
I'd like to add a service aswell, so that this can be used declaratively from your services = {
fiche = {
enable = true;
domain = "example.com";
listen_addr = "0.0.0.0";
port = "9999";
slug size = 3;
output directory = "/var/dir/";
buffer size = 2048;
user name = fiche;
log file = home/www/fiche-log.txt;
banlist = [];
whitelist = [];
https = true; # -S command line option
};
};Should that be a separate PR? and how/where do I add such a configuration option? |
|
I would recommend doing separate PR for service. It will likely require other set of reviewers. I would also recommend trying to first define service as part of your personal configuration first and only then trying to port it to nixos modules. |
|
@pinpox Please squash commits into a single one with the message |
pinpox
force-pushed
the
pinpox-fiche-init
branch
from
4e23933
to
f5a50ce
Compare
pinpox
force-pushed
the
pinpox-fiche-init
branch
from
cda356a
to
07d22cf
Compare
I found a small bug, fixed now and squashed. |
|
yup that's cool. I also found it but looks I didin't have to point it out #101469 (comment) 👍 good work on this. It will probably take a few days for committers to merge this because they're quite overloaded with PRs so please be patient. |
Co-authored-by: Nikolay Korotkiy <sikmir@gmail.com>
|
Can someone merge this or comment on what is missing? |
| @@ -6751,6 +6751,16 @@ | |||
| fingerprint = "A3A3 65AE 16ED A7A0 C29C 88F1 9712 452E 8BE3 372E"; | |||
| }]; | |||
| }; | |||
| pinpox = { | |||
There was a problem hiding this comment.
Please put this into a separate commit with the message maintainers: add pinpox.
| @@ -142,6 +142,8 @@ in | |||
|
|
|||
| ankisyncd = callPackage ../servers/ankisyncd { }; | |||
|
|
|||
| fiche = callPackage ../servers/fiche { }; | |||
There was a problem hiding this comment.
It would be great if you could sort this into a fitting category and alphabetically there.
|
Result of 1 package built:
|
|
Result of 1 package built:
|
Motivation for this change
Include fiche, a command line pastebin service for sharing terminal output with minimal dependencies.
Note: this is my first PR to nixpkgs, feedback is welcome so please let me know what has to be changed!
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)