Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 6.1.14 -> 6.1.16 #101493

Merged
merged 1 commit into from Oct 27, 2020
Merged

virtualbox: 6.1.14 -> 6.1.16 #101493

merged 1 commit into from Oct 27, 2020

Conversation

Magicloud
Copy link
Contributor

@Magicloud Magicloud commented Oct 23, 2020 •
edited

6.1.16 is the latest release of Virtualbox. And it is necessary to have it when using Linux 5.9 kernel.

Motivation for this change

Latest kernel has been updated to 5.9 in unstable channel. Virtualbox before 6.1.16 version cannot be built on it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Magicloud
virtualbox: 6.1.14 -> 6.1.16
e416dc8 
6.1.16 is the latest release of Virtualbox. And it is necessary to have it when using Linux 5.9 kernel.
@endocrimes
Copy link
Member

Result of nixpkgs-review pr 101493 1

4 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.virtualbox
  • linuxPackages_hardkernel_4_14.virtualboxGuestAdditions
  • linuxPackages_hardkernel_latest.virtualbox
  • linuxPackages_hardkernel_latest.virtualboxGuestAdditions
39 packages built:
  • linuxPackages-libre.virtualbox
  • linuxPackages-libre.virtualboxGuestAdditions
  • linuxPackages.virtualbox (linuxPackages_5_4.virtualbox)
  • linuxPackages.virtualboxGuestAdditions (linuxPackages_5_4.virtualboxGuestAdditions)
  • linuxPackages_4_14.virtualbox
  • linuxPackages_4_14.virtualboxGuestAdditions
  • linuxPackages_4_19.virtualbox
  • linuxPackages_4_19.virtualboxGuestAdditions
  • linuxPackages_4_4.virtualbox
  • linuxPackages_4_4.virtualboxGuestAdditions
  • linuxPackages_4_9.virtualbox
  • linuxPackages_4_9.virtualboxGuestAdditions
  • linuxPackages_5_8.virtualbox
  • linuxPackages_5_8.virtualboxGuestAdditions
  • linuxPackages_5_9.virtualbox (linuxPackages_latest.virtualbox)
  • linuxPackages_5_9.virtualboxGuestAdditions (linuxPackages_latest.virtualboxGuestAdditions)
  • linuxPackages_hardened.virtualbox
  • linuxPackages_hardened.virtualboxGuestAdditions
  • linuxPackages_latest-libre.virtualbox
  • linuxPackages_latest-libre.virtualboxGuestAdditions
  • linuxPackages_latest_hardened.virtualbox
  • linuxPackages_latest_hardened.virtualboxGuestAdditions
  • linuxPackages_latest_xen_dom0.virtualbox
  • linuxPackages_latest_xen_dom0.virtualboxGuestAdditions
  • linuxPackages_latest_xen_dom0_hardened.virtualbox
  • linuxPackages_latest_xen_dom0_hardened.virtualboxGuestAdditions
  • linuxPackages_testing_bcachefs.virtualbox
  • linuxPackages_testing_bcachefs.virtualboxGuestAdditions
  • linuxPackages_xen_dom0.virtualbox
  • linuxPackages_xen_dom0.virtualboxGuestAdditions
  • linuxPackages_xen_dom0_hardened.virtualbox
  • linuxPackages_xen_dom0_hardened.virtualboxGuestAdditions
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
  • virtualbox
  • virtualboxExtpack
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack

endocrimes
endocrimes approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me - I'm pinned to kernel 5_8 on the machine I built this on right now tho

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/261

@bryanasdev000 bryanasdev000 mentioned this pull request Oct 27, 2020
Closed
@worldofpeace worldofpeace merged commit f2d8aeb into NixOS:master Oct 27, 2020
@worldofpeace
Copy link
Contributor

Can we port this to 20.09?

@LutzCle LutzCle mentioned this pull request Dec 4, 2020
Closed
@greizgh greizgh mentioned this pull request Dec 22, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Magicloud @endocrimes @nixos-discourse @worldofpeace @rycee @bryanasdev000