[AspectRatio] Correctly compute flex line length #26147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 16, 2020
Because flexbox passes in LayoutUnit::Max(), ng_length_utils used that as the minimum block size, so effectively we ignored the aspect ratio. The test was incorrect. See also w3c/csswg-drafts#5406 R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010, 1045668 Change-Id: I2ed30cb6d9539ea82ac5c22b34c45770fa9a60a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479802 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818452}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2479802
branch
from
7a568fe
to
c1a8b52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because flexbox passes in LayoutUnit::Max(), ng_length_utils used
that as the minimum block size, so effectively we ignored the
aspect ratio.
The test was incorrect. See also w3c/csswg-drafts#5406
R=ikilpatrick@chromium.org, mstensho@chromium.org
Bug: 1083010, 1045668
Change-Id: I2ed30cb6d9539ea82ac5c22b34c45770fa9a60a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479802
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818452}