hdl.ir: Update error message for Instance arguments #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
approved these changes
Oct 16, 2020
|
You need to update the tests too. |
48d4ee4 added the option to specify attributes using Instance arguments, but the error message wasn't updated accordingly.
Xiretza
force-pushed
the
instance-args-errors
branch
from
6067080
to
c9f80ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 49 49
Lines 6409 6409
Branches 1278 1278
=======================================
Hits 5213 5213
Misses 1006 1006
Partials 190 190
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
48d4ee4 added the option to specify attributes using Instance arguments, but the error message wasn't updated accordingly.