Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlformat: refactor #100502

Merged
merged 1 commit into from Oct 18, 2020
Merged

ocamlformat: refactor #100502

merged 1 commit into from Oct 18, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 14, 2020

Motivation for this change

I need to be able to build legacy versions of ocamlformat with an old version of OCaml (currently, the ocamlPackage argument cannot depend on the version argument, which is bound in an inner scope).

cc maintainers @marsam @Zimmi48

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from marsam and Zimmi48 October 14, 2020 14:46
@vbgl vbgl merged commit d149b27 into NixOS:master Oct 18, 2020
@vbgl vbgl deleted the ocamlformat-refactor branch October 18, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@Zimmi48 Zimmi48 Awaiting requested review from Zimmi48

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @marsam