Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riak-cs: delete #100495

Merged
merged 1 commit into from Nov 3, 2020
Merged

riak-cs: delete #100495

merged 1 commit into from Nov 3, 2020

Conversation

DianaOlympos
Copy link
Contributor

Motivation for this change

Now that Riak can run on modern version of OTP, it is time to drop what stopped being supported when Basho died. Riak-CS has had no new commit in 5 years. Time to drop it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DianaOlympos
Copy link
Contributor Author

Moved the throw to pkgs/top-level/aliases.nix

@DianaOlympos
Copy link
Contributor Author

@berbiche I rebased on master, could you re-review now with the changes so we can get that to master, so i can move to getting rid of riak and otp r16 ?

Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the module options would need an entry in nixos/doc/manual/release-notes/rl-2103.xml under "Backward incompatibilities" in the form of

<listitem>
    <para>
    <package>riak-cs</package> package removed along with <varname>services.riak-cs</varname> module.
    </para>
</listitem>
<listitem>
    <para>
    <package>stanchion</package> package removed along with <varname>services.stanchion</varname> module.
    </para>
</listitem>

@DianaOlympos
Copy link
Contributor Author

Well i did add it and deleted it today welp :D ok done

@berbiche
Copy link
Member

berbiche commented Oct 28, 2020

I am not part of the org, so someone else will have to merge this.

Good case for https://github.com/apps/marvin-mk2

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/274

@kevincox kevincox merged commit 8230e62 into NixOS:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants