New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riak-cs: delete #100495
riak-cs: delete #100495
Conversation
dd4d07e
to
970966d
Compare
970966d
to
916d930
Compare
Moved the throw to |
916d930
to
dd10173
Compare
@berbiche I rebased on master, could you re-review now with the changes so we can get that to master, so i can move to getting rid of riak and otp r16 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the module options would need an entry in nixos/doc/manual/release-notes/rl-2103.xml
under "Backward incompatibilities" in the form of
<listitem>
<para>
<package>riak-cs</package> package removed along with <varname>services.riak-cs</varname> module.
</para>
</listitem>
<listitem>
<para>
<package>stanchion</package> package removed along with <varname>services.stanchion</varname> module.
</para>
</listitem>
dd10173
to
63caece
Compare
Well i did add it and deleted it today welp :D ok done |
I am not part of the org, so someone else will have to merge this. Good case for https://github.com/apps/marvin-mk2 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
Now that Riak can run on modern version of OTP, it is time to drop what stopped being supported when Basho died. Riak-CS has had no new commit in 5 years. Time to drop it.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)