New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.pyatv: move pytestCheckHook to checkInputs #100499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.
Namely, you should be doing git cherry-pick -x <rev>
from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build
}: | ||
|
||
buildPythonPackage rec { | ||
pname = "pyatv"; | ||
version = "0.7.2"; | ||
version = "v0.7.4"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v prefix is a version control convention to distinguish between branches and releases, it should be left off
version = "v0.7.4"; | |
version = "0.7.4"; |
src = fetchFromGitHub { | ||
owner = "postlund"; | ||
repo = pname; | ||
rev = version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rev = version; | |
rev = "v${version}"; |
@@ -31,6 +36,8 @@ buildPythonPackage rec { | |||
protobuf | |||
cryptography | |||
netifaces | |||
zeroconf | |||
pytestCheckHook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytestCheckHook | |
pytestCheckHook |
this should be in checkInputs
Please rebase onto master, then we can cherry-pick it onto release |
c8a54d9
to
f0719a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 100499 1
2 packages built:
- python37Packages.pyatv
- python38Packages.pyatv
Motivation for this change
backport of #100489
ZHF: #97479
cc @NixOS/nixos-release-managers
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)