Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noaa-apt: 1.2.0 -> 1.3.0 #100510

Merged
merged 2 commits into from Oct 29, 2020
Merged

noaa-apt: 1.2.0 -> 1.3.0 #100510

merged 2 commits into from Oct 29, 2020

Conversation

trepetti
Copy link
Contributor

@trepetti trepetti commented Oct 14, 2020 •
edited

Motivation for this change

Version bump and making platforms.all explicit to make sure hydra builds binary versions: #99995 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@trepetti
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 14, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@trepetti
Copy link
Contributor Author

Result of nixpkgs-review pr 100510 1

1 package built:
  • noaa-apt

r-burns
r-burns approved these changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on darwin too. LGTM

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 29, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@trepetti
Copy link
Contributor Author

/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 29, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@r-burns
Copy link
Contributor

r-burns commented Oct 29, 2020

Fyi, platforms.all might not be needed for rust packages #101745 (comment). Not really cut and dry though so explicit seems good to be on the safe side.

@r-burns
Copy link
Contributor

r-burns commented Oct 29, 2020

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau October 29, 2020 01:34
timokau
timokau approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to both of you!

@timokau timokau merged commit 105d3a7 into NixOS:master Oct 29, 2020
@trepetti trepetti deleted the noaa-apt-1.3.0 branch October 29, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trepetti @r-burns @timokau