Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devpi-server: fix tests #100508

Merged
merged 1 commit into from Oct 16, 2020
Merged

devpi-server: fix tests #100508

merged 1 commit into from Oct 16, 2020

Conversation

jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 14, 2020 •
edited

Tests relied on a function that has no order guarantee. A fix was merged
to devpi master [1]. We point the package to this commit which should fix
the failing tests on hydra.

[1] devpi/devpi#821

ZHF: #97479
cc @NixOS/nixos-release-managers

Fix build https://hydra.nixos.org/build/127650244/nixlog/2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jfroche
devpi-server: fix tests
44cb4c4 
Tests relied on a function that has no order guarantee. A fix was merged
to devpi master [1]. We point the package to this commit which should fix
the failing tests on hydra.

[1] devpi/devpi#821
@jfroche
Copy link
Contributor Author

jfroche commented Oct 14, 2020

Result of nixpkgs-review pr 100508 1

2 packages built:
  • devpi-client
  • devpi-server

@ofborg ofborg bot requested a review from makefu October 14, 2020 16:44
@makefu
Copy link
Contributor

makefu commented Oct 15, 2020

@GrahamcOfBorg build devpi-server

jonringer
jonringer approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 100508 1

2 packages built:
  • devpi-client
  • devpi-server

@jonringer jonringer merged commit 3a57ec4 into NixOS:master Oct 16, 2020
@jfroche jfroche mentioned this pull request Oct 16, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu makefu approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfroche @makefu @jonringer